DM-42300: Handle day rollover in block parsing #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Mar 6, 2024
| # same as self.dayObs around the beginning or end of the day, so filter | ||
| # with an extra `& (self.data['blockDayObs'] == self.dayObs` when | ||
| # getting the relevant rows. | ||
| rowsForBlock = self.data[(self.data['blockNum'] == block) & (self.data['blockDayObs'] == self.dayObs)] |
There was a problem hiding this comment.
It's more verbose, but I like using numpy.logical_and instead of & to avoid any chance of mixing up bitwise vs. logical in the rare scenarios where that matters. But I think I may be in the minority.
There was a problem hiding this comment.
Yup, I like it - switched 🙂
mfisherlevine
force-pushed
the
tickets/DM-42300
branch
from
cb0bd03
to
b167435
Compare
|
lol, yeah, never read the yaml changes 😄 There's a ticket to make them binary to stop people even considering it (and save space). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.