DM-43297: Add visitInfo to exposures #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
approved these changes
Mar 13, 2024
| viDict = {} | ||
| viDict["exposureTime"] = header.get("EXPTIME") | ||
|
|
||
| # set the midpoint of BEG and END as the DATE |
There was a problem hiding this comment.
It might well not be in DM, but this is what we want for StarTracker images when building the pointing model.
| begin = datetime.datetime.fromisoformat(header.get("DATE-BEG")) | ||
| end = datetime.datetime.fromisoformat(header.get("DATE-END")) | ||
| duration = end - begin | ||
| mid = begin + duration / 2 |
There was a problem hiding this comment.
Could just do mid = begin + (end - begin) / 2 if you care about file length.
There was a problem hiding this comment.
Ah, yeah, I was going to cross-check duration against expTime but it seems like it's a non-issue, so I'll fix that up.
|
|
||
| data = np.asarray(data, dtype=np.float32) | ||
| img = afwImage.ImageF(data) | ||
| maskedIm = afwImage.MaskedImageF(img) |
There was a problem hiding this comment.
Could just do maskedIm = afwImage.MaskedImageF(afwImage.ImageF(data)) if you care about file length.
There was a problem hiding this comment.
That's getting a little much and harder to read 🙂
mfisherlevine
force-pushed
the
tickets/DM-43297
branch
from
6e1609a
to
87ca43e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.