DM-40744: Convert to Pydantic v2 #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rra
force-pushed
the
tickets/DM-40744
branch
2 times, most recently
from
bb2c1cf
to
c37b054
Compare
Update to Pydantic v2 and remove all calls to deprecated methods. Use alpha releases of Safir and documenteer. This unfortunately requires two ugly workarounds, one due to a bug in Pydantic's mypy plugin and one due to a bug in FastAPI. For the first, a bunch of fields in TokenData that should be inherited from TokenUserInfo have to be reiterated because Pydantic's mypy plugin loses a union with None on inherited attributes. For the second, an exception handler for RequestValidationError had to be added to avoid FastAPI attempting to serialize PydanticUndefinedType when the user doesn't provide a query attribute that must be a list.
Pydantic v2 changed some of the doc cross-references that need to be ignored.
The new Pydantic breaks sphinx-autodoc-typehints, and the latter hasn't been fixed yet, so we have to ignore warnings for now because there is one unfixable warning.
Some validators that were supposed to run before Pydantic parsing were instead running after it, which cased test failures with the Kubernetes operator. Fix those and add a better test for the timedelta validator that we use.
rra
force-pushed
the
tickets/DM-40744
branch
from
c37b054
to
392157c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to Pydantic v2 and remove all calls to deprecated methods.
This unfortunately requires two ugly workarounds, one due to a bug in Pydantic's mypy plugin and one due to a bug in FastAPI. For the first, a bunch of fields in TokenData that should be inherited from TokenUserInfo have to be reiterated because Pydantic's mypy plugin loses a union with None on inherited attributes. For the second, an exception handler for RequestValidationError had to be added to avoid FastAPI attempting to serialize PydanticUndefinedType when the user doesn't provide a query attribute that must be a list.