DM-23878: Allow the LDAP group search to be configured #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rra
force-pushed
the
tickets/DM-23878
branch
2 times, most recently
from
4f40eec
to
74ec416
Compare
The IPA LDAP server used in the base cluster only puts full DNs for users in the member field of group LDAP entries. Allow customization of the group search template so that the configuration can tell Gafaelfawr to construct the user DN from a template in order to find the groups they belong to.
Make more use of structured logging when logging the retrieval of the upstream OIDC token, and log the unverified contents of that token at debug level to assist in debugging OIDC issues.
Rather than allowing the user to specify a full template for the group search, instead add a boolean flag saying whether to search by DNs. This requires that the attributes for retrieving user information also be set, but I'm hoping to drop support for getting only groups from LDAP and not also users, so this isn't a major drawback and it allows simplification of the configuration and avoids supporting too many degrees of freedom. Add a test for finding user group membership by DN. Refactor the LDAP storage layer a little to avoid some duplicate code. Restructure the validation of the LDAP settings object to take more advantage of Pydantic v2 validators by using model validators instead of field validators where more appropriate. Remove all of the defaults from the frozen config, since that should be determined entirely by the settings models.
Add a change log and Helm configuration documentation. Stress that the best Gafaelfawr configuration with OIDC is to use LDAP for all user metadata, and that Keycloak is not apparently capable of generating group information in the token that meets our requirements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most LDAP servers put the full user DN in the membership attribute of the group tree. Add a boolean configuration option to specify this search behavior, constructing the DNs using the user base DN and search attribute. This requires that user LDAP information also be enabled, but I'm hoping to drop support for getting only groups from LDAP and not also users, so this isn't a major drawback and it allows simplification of the configuration and avoids supporting too many degrees of freedom.
Log more debugging information about upstream OIDC tokens.
Restructure the validation of the LDAP settings object to take more advantage of Pydantic v2 validators by using model validators instead of field validators where more appropriate. Remove all of the defaults from the frozen config, since that should be determined entirely by the settings models.