DM-41075: Log OIDC exceptions properly #870
Merged
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rra
force-pushed
the
tickets/DM-41075
branch
3 times, most recently
from
c3b58d0
to
6fb3e15
Compare
rra
changed the title
Rather than just raising exceptions during various OIDC provider parse errors, also log those exceptions. Include the body of the response from the token URL if we cannot parse it as valid JSON, since hopefully the chances that it contains secure information are low in that case.
Useful for debugging network and HTTP request issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than just raising exceptions during various OIDC provider parse errors, also log those exceptions. Include the body of the response from the token URL if we cannot parse it as valid JSON, since hopefully the chances that it contains secure information are low in that case.