DM-41424: Improve Redis pool configuration #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The retry specification for the Redis connection pool was passed into the Redis constructor rather than the connection pool constructor, which appears to mean it was unused. Pass it into the connection pool constructor instead, add a socket timeout, and enable socket keepalive. This hopefully will fix a problem we saw where Gafaelfawr never recovered from the Redis server being restarted during Kubernetes maintenance.
rra
force-pushed
the
tickets/DM-41424
branch
2 times, most recently
from
e89070a
to
f14d1e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The retry specification for the Redis connection pool was passed into the Redis constructor rather than the connection pool constructor, which appears to mean it was unused. Pass it into the connection pool constructor instead, add a socket timeout, and enable socket keepalive. This hopefully will fix a problem we saw where Gafaelfawr never recovered from the Redis server being restarted during Kubernetes maintenance.