DM-42384: Fix protocol issues in OpenID Connect server #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop exposing all known claims by default in the issued ID token and instead honor scopes requested by the client. Currently, the supported scopes include the profile and email scopes defined by OpenID Connect (insofar as Gafaelfawr has the data). Set the aud claim on ID tokens to the client ID rather than a fixed audience value that matches the Gafaelfawr issuer, bringing the implementation in line with the intent of the specification. Tie the expiration time of OpenID Connect ID tokens to the expiration of the underlying Gafaelfawr token used as an authentication basis. Require the oidcServer.issuer configuration setting use the https scheme, since the protocol requires that. Include the scope that was used for ID token issuance in the response from the token endpoint, since the spec may require that if unknown scopes were requested. Declare, in the OpenID configuration endpoint, that the only supported response mode is query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop exposing all known claims by default in the issued ID token and instead honor scopes requested by the client. Currently, the supported scopes include the profile and email scopes defined by OpenID Connect (insofar as Gafaelfawr has the data).
Set the aud claim on ID tokens to the client ID rather than a fixed audience value that matches the Gafaelfawr issuer, bringing the implementation in line with the intent of the specification.
Tie the expiration time of OpenID Connect ID tokens to the expiration of the underlying Gafaelfawr token used as an authentication basis.
Require the oidcServer.issuer configuration setting use the https scheme, since the protocol requires that. Include the scope that was used for ID token issuance in the response from the token endpoint, since the spec may require that if unknown scopes were requested.
Declare, in the OpenID configuration endpoint, that the only supported response mode is query.