DM-42384: Verify the database schema on startup #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless it is explicitly disabled (such as by the test suite), check the schema with Alembic during startup to see if it's current and refuse to start if it isn't. Test this by keeping schema validation enabled during Selenium testing, which runs via uvicorn and thus simulates how Gafaelfawr is run in production. This required changing the Selenium fixtures to not be async, since Alembic doesn't like async for some things. They turned out to have no reason to be async, so this was painless. At present, this only handles web application startup, not the Kubernetes operator or the audit or maintenance cron jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless it is explicitly disabled (such as by the test suite), check the schema with Alembic during startup to see if it's current and refuse to start if it isn't. Test this by keeping schema validation enabled during Selenium testing, which runs via uvicorn and thus simulates how Gafaelfawr is run in production.
This required changing the Selenium fixtures to not be async, since Alembic doesn't like async for some things. They turned out to have no reason to be async, so this was painless.
At present, this only handles web application startup, not the Kubernetes operator or the audit or maintenance cron jobs.