DM-43288: Use user info service for health check #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The health check tried to bypass the user info service, but that would require recreating all of the logic that the user info service already had and bypassed checking connectivity to Firestore. Instead, add uncached flags to the user info service and its underlying LDAP and Firestore services that make uncached requests for a proper health check, and use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The health check tried to bypass the user info service, but that would require recreating all of the logic that the user info service already had and bypassed checking connectivity to Firestore. Instead, add uncached flags to the user info service and its underlying LDAP and Firestore services that make uncached requests for a proper health check, and use it.