Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teach sqrbot about CAP #28

Merged
merged 1 commit into from Aug 20, 2019
Merged

Teach sqrbot about CAP #28

merged 1 commit into from Aug 20, 2019

Conversation

RobertLuptonTheGood
Copy link
Contributor

Added CAP JIRA project

@SimonKrughoff SimonKrughoff self-requested a review August 20, 2019 00:22
SimonKrughoff
SimonKrughoff approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@SimonKrughoff SimonKrughoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. The CAP project is not public, but I don't think that's an issue since sqrbot needs to authenticate to the service account for other projects anyway.

@RobertLuptonTheGood
Copy link
Contributor Author

I've asked for it to be made public too -- no reason for secrecy!

@athornton athornton merged commit 0d9f475 into lsst-sqre:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonKrughoff SimonKrughoff SimonKrughoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RobertLuptonTheGood @SimonKrughoff @athornton