Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43772: Add tunablelaser application #268

Merged
merged 1 commit into from
Apr 10, 2024
Merged

DM-43772: Add tunablelaser application #268

merged 1 commit into from
Apr 10, 2024

Conversation

couger01
Copy link
Contributor

Adds tunablelaser application for kubernetes deployment on summit

@couger01 couger01 requested a review from mareuter April 10, 2024 16:50
Copy link
Collaborator

@mareuter mareuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the chart looks good. One thing to take care of though. You also need to add LOVE producer in the love-producer app in the value-summit.yaml config.

tag: c0036
pullPolicy: Always
nexus3: nexus3-docker
env:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to specify OSPL_INFOFILE and OSPL_ERRORFILE. The template usually is:
OSPL_INFOFILE: /tmp/ospl-info-<csc>.log
OSPL_ERRORFILE: /tmp/ospl-error-<csc>.log

Copy link
Collaborator

@mareuter mareuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Looks good to me.

@couger01 couger01 merged commit 700aed9 into main Apr 10, 2024
3 checks passed
@couger01 couger01 deleted the tickets/DM-43772 branch April 10, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants