Add new instrument notebook.

[jbkalmbach]

Documents how to use the new instrument configuration setup when running the Gen 3 AOS pipeline.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[b1quint]

The new notebook is very clear. Thank you for that! I wonder if it is intended to cover the requirements in the LVV-T2228 test case (Step 7 in the Test Script). If not, it is good (I added minor suggestions to the notebook).

[jbkalmbach]

Thanks Bruno! For some reason it looks like your comments didn't show up on the ReviewNB version of the notebook. Can you look and make sure you can see them still?

As for LVV-T2228 it looks like this new update will help in that test case, especially the part where you can set the Defocal Offset configuration to None so that it will be automatically detected from the exposure. This would help in the T2228 where you are pistoning the camera a set amount. Instead of having to manually update that, the new code will know from the exposure headers.

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

b1quint commented on 2023-01-17T21:31:11Z
----------------------------------------------------------------

I believe that we should specify if the reader should execute this notebook in the summit lsp, TTS or USDF. I am not sure if it is implicit, but new people might join the project in the future and they might not know this. Maybe you can even write this at the top of this file since there are other places that includes paths.

[b1quint]

I think this looks good to me. It would be helpful to specify which test environment the reader can use to run this notebook. In any case, I approve this PR.