DM-27414: Rename Hexapod to MTHexapod and Rotator to MTRotator #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvreeven
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
Please review my two questions regarding the module names and fix if you agree. Also next time you may want to consider using "git mv" instead of a file system mv. In this case it is not important since there probably wasn't much git history for these files. Apart from that all looks good to me.
tests/test_config_files.py
Outdated
| self.check_standard_config_files( | ||
| sal_name="Hexapod", | ||
| sal_name="MTHexapod", | ||
| module_name="lsst.ts.hexapod", |
There was a problem hiding this comment.
Shouldn't the module name also be updated to lsst.ts.mthexapod?
tests/test_config_files.py
Outdated
| self.check_standard_config_files( | ||
| sal_name="Rotator", | ||
| sal_name="MTRotator", | ||
| module_name="lsst.ts.rotator", |
There was a problem hiding this comment.
Shouldn't the module name also be updated to lsst.ts.mtrotator?
There was a problem hiding this comment.
Yes. Good catch. (I updated this package before the rename and forgot to go back).
I fixed that and checked that the tests run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.