DM-36148: AstelcoDIMM: improve handling of invalid values #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
force-pushed
the
tickets/DM-36148
branch
4 times, most recently
from
391b714
to
fe0e35e
Compare
r-owen
changed the title
r-owen
force-pushed
the
tickets/DM-36148
branch
from
b808823
to
9989e4c
Compare
from a GET command.
instead of debug, and tweak the text.
* ``status_loop`` was running at full speed, instead of waiting between status requests, which needlessly stressed the DIMM. * ``running_commands`` was not being purged of command that finished. Coupled with the previous problem, this was a significant memory leak.
* Make connect_task always be a task (never None). * Use a named constant for the status interval, instead of a hard-coded value. * Only try to send the DISCONNECT command if connected. * Cancel connect_task in the stop method. One could also cancel it in the disconnect method, but then `disconnect` will need a flag to avoid that so it's safe to call from the connect method.
r-owen
force-pushed
the
tickets/DM-36148
branch
from
9989e4c
to
31385c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from a GET command.