Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tickets/dm 37681 #23

Merged
merged 3 commits into from Jan 30, 2023
Merged

Tickets/dm 37681 #23

merged 3 commits into from Jan 30, 2023

Conversation

teweitsai
Copy link
Collaborator

No description provided.

tribeiro
tribeiro approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few inline comments for you to consider but overall this looks good.

python/lsst/ts/m2com/mock/mock_control_closed_loop.py Show resolved Hide resolved
python/lsst/ts/m2com/mock/mock_control_closed_loop.py Outdated Show resolved Hide resolved
python/lsst/ts/m2com/mock/mock_control_closed_loop.py Show resolved Hide resolved
python/lsst/ts/m2com/mock/mock_control_closed_loop.py Outdated Show resolved Hide resolved
python/lsst/ts/m2com/mock/mock_control_closed_loop.py Outdated Show resolved Hide resolved
python/lsst/ts/m2com/mock/mock_control_closed_loop.py Show resolved Hide resolved
@teweitsai teweitsai merged commit 2372c89 into develop Jan 30, 2023
@teweitsai teweitsai deleted the tickets/DM-37681 branch January 30, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tribeiro tribeiro tribeiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teweitsai @tribeiro