Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33207: improve reading historical data for an indexed SAL component read with index=0 (meaning "all instances") #220

Merged
merged 2 commits into from Jan 12, 2022

Conversation

r-owen
Copy link
Collaborator

@r-owen r-owen commented Jan 11, 2022

No description provided.

@r-owen r-owen force-pushed the tickets/DM-33207 branch 3 times, most recently from 8c43daf to b06ddb3 Compare January 11, 2022 17:14
@r-owen r-owen requested a review from pkubanek January 11, 2022 17:15
Copy link
Member

@pkubanek pkubanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

When reading historical data for an indexed SAL component
using a Remote with index=0 (meaning read all indices):
retrieve the most recent sample for each index, in the order
data was received. Require max_history = 0 or 1 in this case,
because it's too difficult to handle more in chronological order.
@r-owen r-owen merged commit 2b9189b into develop Jan 12, 2022
@r-owen r-owen deleted the tickets/DM-33207 branch January 12, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants