Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-34639: rename the <name>ID field to salIndex, implementing RFC-849 #240

Merged
merged 4 commits into from May 17, 2022

Conversation

r-owen
Copy link
Collaborator

@r-owen r-owen commented May 11, 2022

Warning: the Jenkins CI job will fail until ts_sal is updated

@r-owen r-owen requested a review from wvreeven May 16, 2022 21:59
@r-owen
Copy link
Collaborator Author

r-owen commented May 16, 2022

Unit tests pass with ts_sal davemills/v6.2.0_RC1. Thus I expect Jenkins to be happy once that is merged to develop.

Copy link
Contributor

@wvreeven wvreeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@r-owen r-owen merged commit 5b5d508 into develop May 17, 2022
@r-owen r-owen deleted the tickets/DM-34639 branch May 17, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants