DM-21304 add async BaseCsc.handle_summary_state #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not set the summary state directly. Fix a doc string error. Use a loop for the invalid states to reduce code.
and update documentation to suggest using it
mareuter
approved these changes
Sep 26, 2019
These functions were duplicated in ATDome and ATDomeTrajectory and may well be useful in other code. I would much rather have them in one place (with their unit tests).
r-owen
force-pushed
the
tickets/DM-21304
branch
from
db3ef33
to
fb777b9
Compare
|
The integration test failure is probably due to the fact that I need to temporarily add ticket branches to ts_sal, ts_idl and ts_xml (a side effect of the delay in releasing SAL 4). But we'll see. I have added those branches and done a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.