Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-34986: build with pyproject.toml #72

Merged
merged 4 commits into from Jun 5, 2022
Merged

DM-34986: build with pyproject.toml #72

merged 4 commits into from Jun 5, 2022

Conversation

r-owen
Copy link
Collaborator

@r-owen r-owen commented May 31, 2022

No description provided.

@r-owen r-owen requested a review from wvreeven May 31, 2022 23:27
wvreeven
wvreeven approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@wvreeven wvreeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@r-owen r-owen requested a review from wvreeven June 4, 2022 21:16
@r-owen
Copy link
Collaborator Author

r-owen commented Jun 4, 2022

I reworked the entry point code

wvreeven
wvreeven approved these changes Jun 5, 2022
View reviewed changes
Copy link
Contributor

@wvreeven wvreeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@r-owen r-owen merged commit 6312d5b into develop Jun 5, 2022
@r-owen r-owen deleted the tickets/DM-34986 branch June 5, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvreeven wvreeven wvreeven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r-owen @wvreeven