DM-35878: escalate alarms to OpsGenie #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
force-pushed
the
tickets/DM-35878
branch
4 times, most recently
from
089eb42
to
588c1bd
Compare
r-owen
force-pushed
the
tickets/DM-35878
branch
4 times, most recently
from
a5b6df0
to
5f911bc
Compare
wvreeven
approved these changes
Aug 16, 2022
| f"{escalation_delay=} must be > 0 if and only if" | ||
| f"{escalation_responders=} is not empty" | ||
| ) | ||
| self.escalation_responders = list(escalation_responders) |
There was a problem hiding this comment.
Why is an explicit cast to list needed here if the doc string for escalation_responders already indicates that it is a list?
There was a problem hiding this comment.
I don't try for fully correct types in doc strings (only in formal Python type annotations). list is the shortcut I always for any generic ordered sequence.
r-owen
force-pushed
the
tickets/DM-35878
branch
from
5f911bc
to
0ba0117
Compare
Update the config schema and Alarm to support new fields for responders. Update the model to set those fields. Update the CSC to create a new OpsGenie alert when an alarm's do_escalate field is set.
* Split into User Guide and Developer Guide * Add a section on escalation
r-owen
force-pushed
the
tickets/DM-35878
branch
from
0ba0117
to
2b9313e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.