Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tickets/DM-43403: fix off-axis model for full-array mode and comcam #226

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

tickets/DM-43403: fix off-axis model for full-array mode and comcam #226

wants to merge 19 commits into from

Conversation

jfcrenshaw
Copy link
Collaborator

No description provided.

@jfcrenshaw jfcrenshaw changed the title Tickets/dm 43403 tickets/DM-43403: fix off-axis model for full-array mode and comcam Mar 30, 2024
@jfcrenshaw jfcrenshaw marked this pull request as ready for review April 5, 2024 15:18
jbkalmbach
jbkalmbach approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@jbkalmbach jbkalmbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple small comments. Thanks. Can you hold off on merging until I run a test in the closed loop and make sure everything works and see if there's some improvement as we expect?

python/lsst/ts/wep/task/cutOutDonutsBase.py Outdated
@@ -432,9 +433,12 @@ def cutOutStamps(self, exposure, donutCatalog, defocalType, cameraName):
stampsMetadata["DFC_TYPE"] = np.array(
[defocalType.value] * catalogLength, dtype=str
)
stampsMetadata["DFC_DIST"] = np.array(
stampsMetadata["DET_OFFSET"] = np.array(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keywords for FITS headers have 8 character limit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I changed OFFSET -> DZ to get under character limits

python/lsst/ts/wep/task/cutOutDonutsBase.py Outdated Show resolved Hide resolved
python/lsst/ts/wep/task/cutOutDonutsBase.py Outdated Show resolved Hide resolved
@jfcrenshaw
Passing defocal offset info down to Image objects. Still some things …
a564ce8 
…to iron out.
@jfcrenshaw
Fixed new stamp offset attributes.
f08a930
@jfcrenshaw
Fixing some tests.
684cc20
@jfcrenshaw
Fixed break from rebase. Updated Danish
ee3ae6d
@jfcrenshaw
Fixing tests.
ba81a13
@jfcrenshaw
Fixed batoid raytrace test.
fe9d3c2
@jfcrenshaw
Linting.
90ed112
@jfcrenshaw
removed old save statement in danish test.
2b34e7d
@jfcrenshaw
Fixed how batoidOffsetValue signs are handled.
cc9b6c7
@jfcrenshaw
Better offset defaults for auxtel.
7d8175e
@jfcrenshaw
Fixed real offset test.
85906f9
@jfcrenshaw
Some more tests.
ff2c608
@jfcrenshaw
Trying to fix test that doesn't play well on jenkins.
4e7c455
@jfcrenshaw
Trying to fix test that doesn't play well on jenkins.
3c26fe2
@jfcrenshaw
Linting.
7643c11
@jfcrenshaw
Bounds on Instrument.calcEffDefocalOffset() to avoid bugs.
9d22d2b
@jfcrenshaw
Updated offset names
bf92c27
@jfcrenshaw
Changed the ComCam model back to Detector.
4f82d8d
@jfcrenshaw
Changed the ComCam model back to Detector.
3255322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbkalmbach jbkalmbach jbkalmbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jfcrenshaw @jbkalmbach