Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33326: Fix round-tripping of spectractor spectra #17

Merged
merged 6 commits into from Feb 17, 2022

Conversation

mfisherlevine
Copy link
Collaborator

No description provided.

Copy link

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a unit test to catch round-tripping issues?

spectractor/extractor/spectrum.py Outdated Show resolved Hide resolved
spectractor/extractor/targets.py Outdated Show resolved Hide resolved
@mfisherlevine mfisherlevine changed the title DM-33326: Fix round-tripping of spectractions DM-33326: Fix round-tripping of spectractor spectra Feb 17, 2022
@mfisherlevine
Copy link
Collaborator Author

Not yet for the round-tripping question (hence it all being so broken in the first place!). I think we need a CI package for atmospec+Spectractor tbh, but I think that's out of scope for now. Maybe we can discuss on Monday.

@mfisherlevine mfisherlevine merged commit 2c6a49a into lsst-dev Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants