Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-35647: Resync with upstream again #26

Merged
merged 25 commits into from Jul 20, 2022
Merged

DM-35647: Resync with upstream again #26

merged 25 commits into from Jul 20, 2022

Conversation

mfisherlevine
Copy link
Collaborator

Also fixes compatibility with photutils>=1.5.0 and re-enables some tests.
These changes will be PRed upstream as well.

sylvielsstfr and others added 18 commits March 28, 2022 15:58
@sylvielsstfr
solve the problem of not finding target name in simbad and not findin…
819ec4c 
…g the calspec filename
@sylvielsstfr
suppress unnecessary prints
40fe47a
@jeremyneveu
typo
ec82732
@jeremyneveu
correct image orientations for auxtel images produced with DM-Stack a…
af00c08 
…t CCIN2P3
@jeremyneveu
update of the ratio order 2/1 for holo4_003 with a chimera built from…
dea3263 
… LPNHE meausrements and hologram efficiency model fitted on data
@jeremyneveu
new computation of the camera orientation angle from auxtel ROTPA hea…
ee2d4fc 
…der parameter
@jeremyneveu
add SPECTRACTOR_DECONVOLUTION_SIGMA_CLIP = 20 (default) new sigma cli…
99c1231 
…p parameter and set it to 100 for auxtel.ini
@jeremyneveu
refine the prior on DCCD for auxtel
19e911b
add wavelength fit err in table
e42d258
Merge branch 'master' of https://github.com/LSSTDESC/Spectractor
dd770fb
Merge branch 'master' of https://github.com/LSSTDESC/Spectractor into…
bbca993 
… debug-auxtel
fix name holo4_003/hologram_rotation_angles.txt
b67dd32
fix pickle/lambda functions
7ff61c4
repair apply_max_width_to_bounds to change only the needed bounds and…
e93d189 
… not modifying others
remove pysynphot heavy dependence and add getCalspec light package
20e06c0
@jeremyneveu
Merge pull request LSSTDESC#98 from LSSTDESC/debug-auxtel
44ea2f7 
Debug auxtel
fix and update NOTES
a65b942
@mfisherlevine
Ensure filter size is always odd - required for photutils>=1.5.0
9e7ee90
@mfisherlevine mfisherlevine force-pushed the tickets/DM-35647 branch 2 times, most recently from c8e86e7 to 6a22d0d Compare July 19, 2022 19:44
@mfisherlevine mfisherlevine force-pushed the tickets/DM-35647 branch 3 times, most recently from 53d0ad0 to f3de586 Compare July 20, 2022 01:17
@mfisherlevine mfisherlevine force-pushed the tickets/DM-35647 branch 4 times, most recently from 44e441f to a067998 Compare July 20, 2022 15:32
timj
timj approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. Can you please file an astroquery issue for that Simbad problem if there isn't one?

@mfisherlevine
Use an explicit class instance for simbad queries
5cba9e9 
Importing Simbad and using what looks like a module/class
methods actually instantiates a secret object, and causes
all sorts of problems, so never do that.
@mfisherlevine mfisherlevine merged commit 90263d3 into lsst-dev Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@mfisherlevine @timj @sylvielsstfr @jeremyneveu