DM-37348: Resync with upstream #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t files but use subprocess capabilities instead
…ctrum file name given
refactoring functions for simulator and fullfowardmodel
…in rotated images.
Optimize the atmospheric fit
mfisherlevine
force-pushed
the
tickets/DM-37348
branch
from
1b33a01
to
3c2e35f
Compare
timj
approved these changes
Mar 7, 2023
| @@ -95,6 +96,7 @@ def make_image(): | |||
| psf_poly_params=PSF_POLY_PARAMS_TRUTH, with_stars=False, with_rotation=True, with_noise=False) | |||
|
|
|||
|
|
|||
| @unittest.skip('Skipping to avoid libradtran dependency') | |||
There was a problem hiding this comment.
It's a shame you can't skip these based on actual knowledge of libradtran availability rather than switching it off regardless (if you could do that then this patch could be upstream)
There was a problem hiding this comment.
Agreed. I've filed DM-38259 to address that and upstream these changes.
update actions/checkout to v3
update requirements.txt for getCalspec
mfisherlevine
force-pushed
the
tickets/DM-37348
branch
from
3c2e35f
to
9baf433
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.