Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-38582: Add check for scikit-image version to swap hessian_matrix order. #30

Merged
merged 1 commit into from Apr 6, 2023
Merged

DM-38582: Add check for scikit-image version to swap hessian_matrix order. #30

merged 1 commit into from Apr 6, 2023

Conversation

erykoff
Copy link

@erykoff erykoff commented Apr 5, 2023

No description provided.

@coveralls
Copy link

coveralls commented Apr 5, 2023 •
edited

Pull Request Test Coverage Report for Build 4623509331

  • 9 of 10 (90.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 84.046%
Changes Missing Coverage Covered Lines Changed/Added Lines %
spectractor/tools.py 9 10 90.0%
Files with Coverage Reduction New Missed Lines %
spectractor/extractor/chromaticpsf.py 8 90.52%
Totals Coverage Status
Change from base Build 4368465717: -0.08%
Covered Lines: 6880
Relevant Lines: 8186
💛 - Coveralls

timj
timj approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments but generally looks okay.

spectractor/tools.py Outdated Show resolved Hide resolved
spectractor/tools.py Outdated Show resolved Hide resolved
@erykoff erykoff merged commit 8bb09d7 into lsst-dev Apr 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@erykoff @coveralls @timj