Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-38622: Replace deprecated make_source_mask function #31

Merged
merged 5 commits into from Apr 13, 2023
Merged

DM-38622: Replace deprecated make_source_mask function #31

merged 5 commits into from Apr 13, 2023

Conversation

mfisherlevine
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Apr 10, 2023 •
edited by github-actions bot

Pull Request Test Coverage Report for Build 4681781012

  • 9 of 10 (90.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 84.112%
Changes Missing Coverage Covered Lines Changed/Added Lines %
spectractor/extractor/background.py 9 10 90.0%
Files with Coverage Reduction New Missed Lines %
spectractor/extractor/chromaticpsf.py 9 90.38%
Totals Coverage Status
Change from base Build 4625715074: -0.03%
Covered Lines: 6893
Relevant Lines: 8195
💛 - Coveralls

@mfisherlevine
Copy link
Collaborator Author

Running a full end-to-end test for you on this, will confirm once it's passed (testing both 1.6.0 and 1.7.0 photutils)

@mfisherlevine
Copy link
Collaborator Author

Passes with both - merge any time you like 👍

@ktlim ktlim merged commit 2b24840 into lsst-dev Apr 13, 2023
1 check passed
@ktlim ktlim deleted the tickets/DM-38622 branch April 13, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mfisherlevine @coveralls @ktlim