DM-38745: Resync with upstream #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… collection surface
…tion of hessian_matrix function default arguments
…n_matrix function default arguments
Repair astrometry doctests
Pull Request Test Coverage Report for Build 5966019874
💛 - Coveralls |
mfisherlevine
force-pushed
the
tickets/DM-38745
branch
from
02b7bf1
to
ea9b949
Compare
mfisherlevine
force-pushed
the
tickets/DM-38745
branch
from
ea9b949
to
c456f79
Compare
czwa
approved these changes
Aug 24, 2023
spectractor/astrometry.py
Outdated
| @@ -263,6 +264,8 @@ def __init__(self, image, wcs_file_name="", output_directory="", gaia_mag_g_limi | |||
| Input Spectractor Image. | |||
| wcs_file_name: str, optional | |||
| The path to a WCS fits file. WCS content will be loaded (default: ""). | |||
| gaia_file_name: str, optional | |||
| The path to a Gaia caralog ecsv file (default: ""). | |||
There was a problem hiding this comment.
This typo is from Jérémy, not from my change, but I've pushed a fix for it anyway, as we're about to upstream all our changes. I hope you didn't spend much time looking this part of the changes over!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.