New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-39583: Fix lots of deprecation warnings #40
Conversation
Sometimes there were explicit close() calls but other times the file was left open.
I was not expecting a core dump... nosetests does not core dump for me locally (neither does pytest) but I do skip one test. |
Pull Request Test Coverage Report for Build 5601831423
💛 - Coveralls |
@mfisherlevine good news is that python 3.11 built everything fine. The 3.10 segv was a bit odd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look fine to me, but give we'll want to upstream these changes, I'd like Jérémy to take a look too. I'll send it to him, and pass on the comments, and then you're good to merge.
These look fine to me too! |
There are still 25 remaining when the tests run but I don't want to fix all the matplotlib problems.