Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-39583: Fix lots of deprecation warnings #40

Merged
merged 7 commits into from Jul 19, 2023
Merged

Conversation

timj
Copy link
Member

@timj timj commented Jul 19, 2023

There are still 25 remaining when the tests run but I don't want to fix all the matplotlib problems.

@timj timj requested a review from mfisherlevine July 19, 2023 15:36
@timj
Copy link
Member Author

timj commented Jul 19, 2023

I was not expecting a core dump... nosetests does not core dump for me locally (neither does pytest) but I do skip one test.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5601831423

  • 78 of 86 (90.7%) changed or added relevant lines in 6 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 87.29%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spectractor/extractor/spectrum.py 35 43 81.4%
Files with Coverage Reduction New Missed Lines %
spectractor/extractor/chromaticpsf.py 9 90.38%
Totals Coverage Status
Change from base Build 5326706949: -0.1%
Covered Lines: 7156
Relevant Lines: 8198

💛 - Coveralls

@timj
Copy link
Member Author

timj commented Jul 19, 2023

@mfisherlevine good news is that python 3.11 built everything fine. The 3.10 segv was a bit odd.

Copy link
Collaborator

@mfisherlevine mfisherlevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look fine to me, but give we'll want to upstream these changes, I'd like Jérémy to take a look too. I'll send it to him, and pass on the comments, and then you're good to merge.

@jeremyneveu
Copy link

These look fine to me too!

@timj timj merged commit cf1727e into lsst-dev Jul 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants