Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-40988: Resync with upstream #47

Merged
merged 29 commits into from Oct 11, 2023
Merged

DM-40988: Resync with upstream #47

merged 29 commits into from Oct 11, 2023

Conversation

mfisherlevine
Copy link
Collaborator

No description provided.

Jérémy Neveu and others added 29 commits September 28, 2023 10:35
check for degenerate vectors in jacobian (causing impossibility to in…
4f6253e 
…vert JT_W_J)
update version number 3.0 -> 3.0.1
d0dc522
if fitted regularisation parameter is away from optimal one by 3 orde…
abee92b 
…rs of magnitude, use the optimal one (determined with the spectrophotometric uncertainty principle)
fix A1 label
18c18c6
fix A1 label
7640af2
fix print of target lines
2804a09
fix print of uncertainties
145f5da
fix print of uncertainties
3e81e35
robust initialisation of polynomial parameters in fit_transverse_psf1…
881913f 
…d using only brightest psf profiles (>10% of max amplitude)
prefit y_c parameters in ChromaticPSF2D before fitting all parameters
f6b4fe6
find_target: improve first guess on gamma Moffat parameter before fit
330d2b4
slight improvement of logging to better read the logs
ac677fc
decrease guess in find_target
bc3ee52
add float64 as pixel types for evaluate_moffat2d (useful for plots)
5f357fd
test spectrum v3.0.1
6ac50cf
add lsst.utils disable_implicit_threading
d49989e
tuning of find_target bounds
a235dc0
save memory in set_mask(): compute directly of PSF cube of type bool …
28eab6a 
…instead of float
save memory: stay sparse when adding oultiers
b1920b9
save memory: don't recompute ChromaticPSF2D with full shape including…
f093c0d 
… background side regions
add lsst_utils
4aafc00
add outliers for any format of sparse weight matrix
064ae72
add outliers for any format of sparse weight matrix
1791159
robuts selection of best transverse profiles for ChromaticPSF1D fit i…
b2a67c2 
…nitialiation
remove deprecated warning from colormaps
fbf38ab
repair fit_multispectra
674c9e3
sync fit_spectrogram.py with extractor methods
4a6ef43
@jeremyneveu
Merge pull request LSSTDESC#139 from LSSTDESC/autoreg
20c69d6 
Robust extraction with better guess for regularisation parameter; fix degeneracies
@mfisherlevine
Add utils to table file
1fa2e35
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6486067175

  • 134 of 140 (95.71%) changed or added relevant lines in 11 files are covered.
  • 16 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.7%) to 91.395%
Changes Missing Coverage Covered Lines Changed/Added Lines %
spectractor/extractor/chromaticpsf.py 60 62 96.77%
spectractor/fit/fitter.py 38 42 90.48%
Files with Coverage Reduction New Missed Lines %
spectractor/extractor/chromaticpsf.py 4 91.68%
spectractor/simulation/simulator.py 5 91.15%
spectractor/extractor/spectrum.py 7 91.51%
Totals Coverage Status
Change from base Build 6314932963: 0.7%
Covered Lines: 6957
Relevant Lines: 7612
💛 - Coveralls

@mfisherlevine mfisherlevine merged commit bb6c461 into lsst-dev Oct 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czwa czwa czwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@mfisherlevine @coveralls @czwa @jeremyneveu