afw/DM-3549: transform features in support of new astrometry fitter #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-3549
branch
from
58a8cf7
to
cb818c2
Compare
r-owen
reviewed
Oct 5, 2016
| @@ -109,7 +109,7 @@ class AffineTransform { | |||
| ) : _linear(linear), _translation(translation) {} | |||
|
|
|||
| /** Construct an AffineTransform from a LinearTransform. */ | |||
| explicit AffineTransform(LinearTransform const & linear) | |||
There was a problem hiding this comment.
I'm just curious: why is this change helpful?
There was a problem hiding this comment.
It allows you to pass a LinearTransform to functions that take an AffineTransform without an explicit conversion. In particular, that includes overloaded operators, so it lets me do linear1 + affine2 instead of AffineTransform(linear1) + affine1.
|
This looks like a very useful change |
TallJimbo
force-pushed
the
tickets/DM-3549
branch
from
cb818c2
to
8b260e1
Compare
This will allow LinearTransforms to participate in AffineTransform operator overloading with the appropriate promotion.
TallJimbo
force-pushed
the
tickets/DM-3549
branch
from
8b260e1
to
a186269
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.