DM-7976 fix reading old coadds (CoaddInputs/ExposureTable) #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Oct 14, 2016
| daf::base::PropertySet md; | ||
| auto nullVisitInfoPtr = std::make_shared<image::VisitInfo>(md); | ||
| output.setVisitInfo(nullVisitInfoPtr); | ||
| } |
There was a problem hiding this comment.
I'm a little surprised you consider it better to default-construct a VisitInfo here rather than leave it an empty pointer. Is having a non-null VisitInfo required for all Exposure objects (even coadd?!) and hence something you want to enforce for ExposureRecords as well?
There was a problem hiding this comment.
I would prefer to leave it an empty pointer. How do I do that?
There was a problem hiding this comment.
If you simply do nothing, it should already be set to an empty pointer. If you want to make it explicit (for readers of the code), you could do:
output.setVisitInfo(nullptr);
I'm ambivalent about which is better.
There was a problem hiding this comment.
Thank you. I'll make it explicit. A big improvement in any case.
r-owen
force-pushed
the
tickets/DM-7976
branch
from
ae76f44
to
9e5fb29
Compare
r-owen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.