Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load LST into VisitInfo tickets/DM-8052 #116

Merged
merged 2 commits into from Nov 18, 2016
Merged

Load LST into VisitInfo tickets/DM-8052 #116

merged 2 commits into from Nov 18, 2016

Conversation

parejkoj
Copy link
Contributor

@parejkoj parejkoj commented Nov 2, 2016

Adding LST into VisitInfo, by way of a "fake" ERA.

Copy link
Contributor

@r-owen r-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a named tuple is an improvement. I am not convinced using explicit data1/data2 instead of a list of data is an improvement, but it will be easy to revert if we ever decide we want additional data.

@parejkoj
Copy link
Contributor Author

I agree that the *1/*2 split wasn't necessarily an improvement, but I wasn't sure how best to handle the non-visitInfo data (HA/LST) that we're also checking. As you say, it's easy enough to bundle all the data values into a tuple if we want.

@parejkoj parejkoj merged commit 22f008f into master Nov 18, 2016
@ktlim ktlim deleted the tickets/DM-8052 branch August 25, 2018 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants