afw/DM-8221: Add test helper for comparing Schemas. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
approved these changes
Nov 14, 2016
| indicating which features of schema items to compare. The returned | ||
| diff will always show all differences, but no diff will be shown if | ||
| the only differences are not included in the flags. Default is | ||
| `lsst.afw.table.Schema.IDENTICAL`, which checks everything. |
There was a problem hiding this comment.
It seems a bit odd to show diffs that are not in the flags, but I'm guessing that made the code simpler.
In any case it's a minor point. This seems like a really useful utility.
There was a problem hiding this comment.
You guessed correctly. It'd be really hard to actually modify the diff to pay attention to the flags.
| msg = "%s, %s, and %s differ:\n%s" % (components[0].capitalize(), | ||
| ", ".join(components[1:-1]), | ||
| components[-1], diff) | ||
| return msg |
There was a problem hiding this comment.
I think this would be a bit cleaner if you made a separate function that created the list of components (with or without capitalization--that could always be done afterwards since it would be a short string). Whether the gain is worth the cost of further coding is a valid question.
TallJimbo
force-pushed
the
tickets/DM-8221
branch
from
ef591f8
to
7484903
Compare
TallJimbo
force-pushed
the
tickets/DM-8221
branch
from
7484903
to
494f203
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is test support code used to help diagnose DM-8221 that may be useful long-term.