DM-1076, remove need of unit tests to setVersion(0), and move tests to d... #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| result.insert(result.end(), i->first); | ||
| } else { | ||
| result.insert(result.end(), i->first.substr(0, dot)); | ||
| result.insert(result.end(), i->first.substr(0, sep)); | ||
| } | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Use brackets and spacing in if/else clause.
Also clarify the comment such that it is unambiguous whether "nan or 0" refers to the table version or the separator.
pgee2000
force-pushed
the
u/pgee/DM-1076
branch
5 times, most recently
from
c423183
to
1b04f1e
Compare
…o default version. Note that there are several version tests in the unit tests which should not be changed. Also needed to change Schema::getNames to use the '_' separator for version > 0. Also included responses to review comments
pgee2000
force-pushed
the
u/pgee/DM-1076
branch
from
1b04f1e
to
a25b9eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...efault version.
Note that there are several setVersion(0) in the unit tests which should not be changed,
because they are actually testing whether version 0 tables work, or how they compare with
version 1 tables.
Also needed to change Schema::getNames to use the '_' separator for version > 0.