Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stripping WCS metadata reliable #166

Merged
merged 2 commits into from Feb 7, 2017
Merged

Make stripping WCS metadata reliable #166

merged 2 commits into from Feb 7, 2017

Conversation

r-owen
Copy link
Contributor

@r-owen r-owen commented Feb 7, 2017

Make makeWcs(metadata, stripMetadata) reliably strip
metadata (if the stripMetadata is true) by stripping
the argument, rather than an internal copy that may be
a deep copy.

Copy link
Contributor

@PaulPrice PaulPrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whitespace changes should probably go in a separate commit, but apart from that this looks fine. I think the whole approach in this function should be revised (get rid of the _metadata vs metadata distinction), but your change gets the job done.

Make `makeWcs(metadata, stripMetadata)` reliably strip
metadata (if the `stripMetadata` is true) by stripping
the argument, rather than an internal copy that may be
a deep copy.
@r-owen r-owen merged commit 199f25b into master Feb 7, 2017
@ktlim ktlim deleted the tickets/DM-9298 branch August 25, 2018 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants