-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-7913: Implement RFC-240: make Angle's named methods const... #184
Merged
Commits on Mar 9, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 20b8a2a - Browse repository at this point
Copy the full SHA 20b8a2aView commit details -
Move inline method definitions to end of Angle.h.
This allows method bodies to use the full Angle API, particularly operators. Trivial getters have not been moved to minimize code duplication.
Configuration menu - View commit details
-
Copy full SHA for 2e6fa18 - Browse repository at this point
Copy the full SHA 2e6fa18View commit details -
Give Angle.wrap*() a functional API.
Client code is generally simpler if wrap methods return an altered Angle instead of modifying the object they are called on.
Configuration menu - View commit details
-
Copy full SHA for e4ab28f - Browse repository at this point
Copy the full SHA e4ab28fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9290528 - Browse repository at this point
Copy the full SHA 9290528View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ffedb2 - Browse repository at this point
Copy the full SHA 9ffedb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8590cc7 - Browse repository at this point
Copy the full SHA 8590cc7View commit details -
This change allows Angles to be used in compile-time expressions and take advantage of noexcept optimizations. It also simplifies some existing metaprogramming using C++11-only tools.
Configuration menu - View commit details
-
Copy full SHA for 5bfd67f - Browse repository at this point
Copy the full SHA 5bfd67fView commit details -
Documentation cleanup pass for Angle.
This commit ensures all API elements are documented, and that documentation complies with current style guidelines.
Configuration menu - View commit details
-
Copy full SHA for 07b031b - Browse repository at this point
Copy the full SHA 07b031bView commit details
Commits on Mar 10, 2017
-
Move to/fromUnitSphereDistanceSquared to afw::table.
These methods were added to Angle as part of 2b49698 to be used in table::Match. They have not been used anywhere else, their use case is more specific than other Angle operations, and they do not need any access to Angle's internals (cf. Effective C++ 3rd. Ed., Item 23). In addition, making them an implementation detail of Match reduces coupling between afw::geom and afw::table, which may be useful in the long run.
Configuration menu - View commit details
-
Copy full SHA for 7f9d117 - Browse repository at this point
Copy the full SHA 7f9d117View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.