Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-7913: Implement RFC-240: make Angle's named methods const... #184

Merged
merged 9 commits into from
Mar 11, 2017

Commits on Mar 9, 2017

  1. Configuration menu
    Copy the full SHA
    20b8a2a View commit details
    Browse the repository at this point in the history
  2. Move inline method definitions to end of Angle.h.

    This allows method bodies to use the full Angle API, particularly
    operators. Trivial getters have not been moved to minimize code
    duplication.
    kfindeisen committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    2e6fa18 View commit details
    Browse the repository at this point in the history
  3. Give Angle.wrap*() a functional API.

    Client code is generally simpler if wrap methods return an altered
    Angle instead of modifying the object they are called on.
    kfindeisen committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    e4ab28f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9290528 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9ffedb2 View commit details
    Browse the repository at this point in the history
  6. Remove NullAngle.

    kfindeisen committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    8590cc7 View commit details
    Browse the repository at this point in the history
  7. C++11 update pass for Angle.

    This change allows Angles to be used in compile-time expressions and
    take advantage of noexcept optimizations. It also simplifies some
    existing metaprogramming using C++11-only tools.
    kfindeisen committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    5bfd67f View commit details
    Browse the repository at this point in the history
  8. Documentation cleanup pass for Angle.

    This commit ensures all API elements are documented, and that
    documentation complies with current style guidelines.
    kfindeisen committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    07b031b View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2017

  1. Move to/fromUnitSphereDistanceSquared to afw::table.

    These methods were added to Angle as part of
    2b49698 to be used in table::Match.
    They have not been used anywhere else, their use case is more specific
    than other Angle operations, and they do not need any access to
    Angle's internals (cf. Effective C++ 3rd. Ed., Item 23). In addition,
    making them an implementation detail of Match reduces coupling between
    afw::geom and afw::table, which may be useful in the long run.
    kfindeisen committed Mar 10, 2017
    Configuration menu
    Copy the full SHA
    7f9d117 View commit details
    Browse the repository at this point in the history