Tickets/dm 2471 -- astrometry has a bug in retrieving TAN_PIXELS and it exposes the need for a better API #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add overloaded member functions hasTransform and getTransform to cameraGeom Detector, which accept a CameraSys or a CameraSysPrefix. This greatly simplifies getting appropriate transforms from the detector's transform map, since one need not explicitly first generate a CameraSys for that detector. Added a test for the new functions to testDetector.py. Made a minor improvement to documentation in TransformMap.h Fix grammatical errors in two doc strings.
image/utils.py contained a function clipImage that was not used anywhere. not tested, and badly broken. At RHL's request I fixed it to the point of making pyflakes happy and will file a ticket for RHL to add a unit test. I also added from __future__ import absolute_import, division Fix image.utils.clipImage, or at least make pyflakes linter happy
Added a new function lsst.image.utils.getDistortedWcs. Added a unit test for it. To write the unit test I added a new "modFunc" argument to cameraGeom.getUtils.DetectorWraper.__init__ to allow flexibile modification of wrapper attributes just before constructing the Detector. Finally, I used that new modFunc argument to replace two other arguments and updated the test that used those other arguments to use modFunc instead. Switch from using cast_TanWcs to TanWcs.cast Fix a typo in a doc string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.