Review comments for DM-1197 (Support some mixed-type operations for Point and Extent) #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Extent<int,N> floor(Extent<double,N> const & input); | ||
|
|
||
| /** | ||
| * Return the component-wise floor (round towards more positive). |
There was a problem hiding this comment.
"ceil", not "floor".
This adds mixed-type operators for Point and Extent, as well as new floor, ceil, and truncate functions for Extent, to help deal with some unfortunate differences between C++ and Python in how division is expected to behave for integers.
Methods are much less verbose than the existing conversion constructors in Python.
TallJimbo
force-pushed
the
tickets/DM-1197
branch
from
3fe36c3
to
8196a1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.