Tickets/dm 10091 Patch up DM-9952 #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Masked by failing to fix daf_persistence's usage of hdu=0 until this working on this ticket
The BackgroundList code needs a serious rewrite!
hsinfang
reviewed
Apr 4, 2017
| hdu = -1 | ||
| else: | ||
| hdu -= 1 # we want to start at 0 (post RFC-304), but are about to increment | ||
|
|
There was a problem hiding this comment.
Code changes look fine although I don't understand the commit message and its relationship with pipe_tasks's testProcessCcd.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.