DM-10271: Support deleting slices of a catalog. #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
approved these changes
Apr 21, 2017
| throw py::error_already_set(); | ||
| } | ||
| if (step != 1) { | ||
| throw py::index_error("Slice step must not be negative"); |
There was a problem hiding this comment.
step != 1 does not necessarily mean it's negative.
| self.assertEqual([r.get(key) for r in catalog], | ||
| [0, 1, 2, 3, 8, 9]) | ||
| with self.assertRaises(IndexError): | ||
| del catalog[1:3:-1] |
There was a problem hiding this comment.
Check other steps beside -1.
tests/testSimpleTable.py
Outdated
| with self.assertRaises(IndexError): | ||
| del catalog[1:3:-1] | ||
| with self.assertRaises(IndexError): | ||
| del catalog[50] |
There was a problem hiding this comment.
Well, that's rather inconvenient and counter-intuitive: I can delete a slice but not a single element! I think you need to support this.
There was a problem hiding this comment.
You can delete a single element, just not one with index >= len(catalog).
TallJimbo
force-pushed
the
tickets/DM-10271
branch
2 times, most recently
from
f119141
to
6c63c9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpful in the peak-transferring code needed on the meas_algorithms branch for this issue.