DM-10973: Make SkyWcs transform to IcrsCoord instead of SpherePoint #247
Conversation
| virtual ndarray::Array<double, 2, 2> dataFromArray(Array const &arr) const override; | ||
|
|
||
| virtual Point pointFromData(std::vector<double> const &data) const override; | ||
| virtual int getNPoints(Array const &arr) const override; |
There was a problem hiding this comment.
Is Array::size private? Otherwise this seems like a pretty pointless (and confusing) function.
There was a problem hiding this comment.
Because for GenericEndpoint.getNPoints Array is a 2-dimensional ndarray and so can't use size
| @@ -55,6 +57,31 @@ def assertCoordsAlmostEqual(testCase, coord0, coord1, maxDiff=0.001*afwGeom.arcs | |||
|
|
|||
|
|
|||
| @lsst.utils.tests.inTestCase | |||
| def assertCoordListsAlmostEqual(testCase, coordlist0, coordlist1, maxDiff=0.001*afwGeom.arcseconds, msg=None): | |||
| """!Assert that two lists of IcrsCoords represent almost the same point on the sky | |||
There was a problem hiding this comment.
So Doxygen recognizes it as Doxygen documentation
| testCase.assertEqual(len(coordlist0), len(coordlist1), msg=msg) | ||
| sepArr = np.array([sp0.toIcrs().angularSeparation(sp1.toIcrs()) | ||
| for sp0, sp1 in zip(coordlist0, coordlist1)]) | ||
| badArr = sepArr > maxDiff |
There was a problem hiding this comment.
I assume angularSeparation is defined to be always positive. Probably is, but just checking.
| @@ -132,6 +106,39 @@ Point2Endpoint::Point2Endpoint(int nAxes) : BaseVectorEndpoint<Point2D>(2) { | |||
| } | |||
| } | |||
|
|
|||
| std::vector<double> Point2Endpoint::dataFromPoint(Point const& point) const { | |||
There was a problem hiding this comment.
Does it matter that it is now only defined for the derived class and no longer for the base class BaseVectorEndpoint<Point>?
There was a problem hiding this comment.
If so, I think the comment @note Subclasses must provide arrayFromData should be updated to include dataFromPoint, dataFromArray and pointFromData.
r-owen
force-pushed
the
tickets/DM-10973
branch
3 times, most recently
from
67f28bc
to
119a2ae
Compare
Let clang-format 5.0.0 normalize end comments for namespaces and a bit of comment indentation.
Also change `SkyWcs` to use `IcrsCoord` instead of `SpherePoint`.
No description provided.