Tickets/DM-11010 #255
Merged
Tickets/DM-11010 #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug in which the peaks in the Footprint transform method incorrectly determined the position of the peak in the newly transformed Footprint. Fixed to correct behavior.
r-owen
approved these changes
Jul 6, 2017
tests/test_footprint1.py
Outdated
| # Multiplied by two because that is the linear transform scaling | ||
| # factor | ||
| self.assertEqual(peak.getIx(), truth[0]*2) | ||
| self.assertEqual(peak.getIy(), truth[1]*2) |
There was a problem hiding this comment.
I suggest making the linear transform scaling factor a named constant (used when creating the linear transform above and again here).
Create a test for Footprint peak transformation, to ensure the peaks in the post transformed Footprint are in the correct places.
natelust
force-pushed
the
tickets/DM-11010
branch
from
c1cf549
to
146da1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.