DM-6718 Add str and repr for afw catalog/record #256
Conversation
parejkoj
changed the title
|
Great addition John, thanks! |
| from future.utils import with_metaclass | ||
|
|
||
| import numpy as np | ||
|
|
||
| from lsst.utils import continueClass, TemplateMeta | ||
| from .base import BaseRecord, BaseCatalog | ||
|
|
||
| __all__ = ["Catalog"] | ||
|
|
There was a problem hiding this comment.
This is in the wrong place, it should be moved back where it was. I too was bitten by this recently. Our coding guidelines state it should be at the top (to mimic pep8). My linter was still saying the top was not the right place, and it turns out I needed to update my linter to a newer version.
There was a problem hiding this comment.
Is this something that's been announced to the LSST community? The last I'd heard about this issue I'd gotten the impression that it was the guidelines that were not PEP8-compliant (though I can see now that they are).
There was a problem hiding this comment.
There was a problem hiding this comment.
Got it! Yes, my flake8 needed to be upgraded.
| if self.isContiguous(): | ||
| return str(self.asAstropy()) | ||
| else: | ||
| fields = ' '.join(x.field.getName() for x in self.schema) |
There was a problem hiding this comment.
Why does the Astropy implementation print out rows (so you get something that looks like a table) and ours does not?
There was a problem hiding this comment.
We discussed this offline, but I'll make a response here, after talking it over with @SimonKrughoff :
We don't want to be constantly patching over the annoyances we have with our non-contiguous tables. We should instead fix them to behave better in general. So, instead of adding extra special casing to make non-contiguity "nicer" in each individual case, we'll do a "minimum functionality" thing and fix the non-contiguous tables themselves, by e.g. making numpy views into them that behave correctly.
parejkoj
force-pushed
the
tickets/DM-6718
branch
from
1436020
to
8b281cb
Compare
Add _repr_html_ for jupyter pretty-printing
parejkoj
force-pushed
the
tickets/DM-6718
branch
from
8b281cb
to
a69f52c
Compare
No description provided.