Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-7477: Increase mask plane size to 32 bits #258

Merged
merged 3 commits into from
Jul 13, 2017
Merged

DM-7477: Increase mask plane size to 32 bits #258

merged 3 commits into from
Jul 13, 2017

Commits on Jul 13, 2017

  1. Change mask type to int32 

    Changed Mask pixel type(def) to int32, adding alias to MaskPixel
in python as well. This change triggered a renaming of the python
template alias from MaskU to MaskX to avoid type confusion.
Because of the new pybind11 continue class abstract base classes
this new name could be mostly hidden behind the abc name "Mask",
as MaskX is now the default type to construct when calling the
abc.
    @natelust
    natelust committed Jul 13, 2017
    Configuration menu
    Copy the full SHA
    7b97907 View commit details
    Browse the repository at this point in the history

  2. Add legacy support for HeavyFootprint

    @natelust
    natelust committed Jul 13, 2017
    Configuration menu
    Copy the full SHA
    a5a8116 View commit details
    Browse the repository at this point in the history

  3. Test reading legacy HeavyFootprint 

    Changing the mask pixel type necessitated creating a way to read
HeavyFootprints that were saved with the old MaskPixel type. Test
that a old HeavyFootprint is loadable, has the correct values,
and is comprised of the new MaskPixel type.
    @natelust
    natelust committed Jul 13, 2017
    Configuration menu
    Copy the full SHA
    c1b2468 View commit details
    Browse the repository at this point in the history