DM-11237: Cleanup standard output in sipterms.cc. #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the print statements look like debugging aids, and have been removed on the grounds that they should never have been committed. Several are used to indicate test progress, and have been replaced with logging statements (at DEBUG level so they don't pop up in normal runs). A better solution would be to factor the single monolithic test case into one for each function, but I'm not sure setting up a proper fixture is worth the time in this case.
RobertLuptonTheGood
approved these changes
Jul 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the print statements look like they were added when somebody was debugging something, and have been removed on the grounds that they should never have been committed. Several are used to indicate test progress, and have been replaced with logging statements (at
DEBUGlevel so they don't pop up in normal runs).A better solution would be to factor the single monolithic test case into one for each function, but I'm not sure setting up a proper fixture is worth the time in this case.