Implement PhotoCalib ops that output to catalogs. #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
approved these changes
Jul 31, 2017
| auto maggiesKey = sourceCatalog.getSchema().find<double>(outField + "_calFlux").key; | ||
| auto maggiesErrKey = sourceCatalog.getSchema().find<double>(outField + "_calFluxErr").key; | ||
| for (auto & record : sourceCatalog) { | ||
| auto result = instFluxToMaggies(record.get(instFluxKey), record.get(instFluxErrKey), |
There was a problem hiding this comment.
Consider auto const.
I'm also curious if auto const & would be give better performance, but I hope the answer is "no".
There was a problem hiding this comment.
It shouldn't change the performance, but we can't use it here anyway because we also call set.
| auto magKey = sourceCatalog.getSchema().find<double>(outField + "_mag").key; | ||
| auto magErrKey = sourceCatalog.getSchema().find<double>(outField + "_magErr").key; | ||
| for (auto & record : sourceCatalog) { | ||
| auto result = instFluxToMagnitude(record.get(instFluxKey), record.get(instFluxErrKey), |
Names used here will have to be updated when RFC-322 is adopted.
TallJimbo
force-pushed
the
tickets/DM-10729
branch
from
bb37795
to
a8785b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Names used here will have to be updated when RFC-322 is adopted.
This PR is a new one (against master) that supercedes #262.