DM-11514: Fix some pytest problems

[timj]

• Use correct name of pytest initialization function.
• Rename a test file.
• Cleanup logic in SConscript to ignore pybind11 test files.

[kfindeisen]

I'm a bit surprised by the "Ignore..." and "Fix name of..." commits, because I've run pytest with no arguments from the command line with no problems. Is this an OS- or otherwise environment-specific issue?

[timj]

@kfindeisen if you run pytest without arguments it will discover most of the tests but not the one test that was named incorrectly. Also, the ignore is for SCons' benefit so that it won't try to test that file. If you ask pytest to test a file without any tests in it, pytest returns non-zero exit status as it assumes you've made a mistake somewhere. If you ask pytest to run tests for tests/*.py then that one file without tests in it will be ignored on the basis that other tests were run okay. In the current implementation of sconsUtils we run pytest separately for each file so trigger this problem. Hiding the files from testing is the correct approach.

[kfindeisen]

Ok, I didn't realize sconsUtils did its own file search.

And yes, I understand the problem with testDir.py. Sorry for mistaking it for a library!

[timj]

Should have mentioned this PR is triggered by lsst/sconsUtils#34.

[timj]

@kfindeisen does this count as a review?

[kfindeisen]

No, I was asking for personal edification.

[r-owen]

I'm not entirely sure I understand the changes to stop testing for afwdir in tests/SConscript, but I assume they are correct (were you able to test them?).

One thing to consider: move the test in (formerly) testDir.py to test_sourceTable.py. The name of the test is a bit unclear and what it tests is an aspect of SourceTable. That said, it probably tests an aspect of all tables and so perhaps out to be rewritten to use SimpleTable. But I think simply moving it and deleting the old file would be good enough.

[r-owen]

I'm curious: why is this change needed? I suppose if you use pytest tests/*.py instead of pytest, as we may have to do initially, that would explain it.

[timj]

This is needed to stop SCons from thinking that the pybind11 .py files are things that should be tested. This is important when we are in a mode where pytest runs each test file separately because pytest exits with bad status if no tests are found. See my comment above replying to @kfindeisen. With these changes pytest without arguments would work but sconsUtils is not yet set up to do that (that's a change we can make later once the basics are done).

[timj]

The tweaking of the {{afwdata}} stuff in the SCons file is a left over of DM-609. We don't need to filter out any tests because the C++ tests trap the situation themselves. I have tested with and without afwdata.