Make it possible to specify an origin (e.g. PARENT) with e.g. im[bbox] #272
Conversation
|
|
||
| try: | ||
| _origin = imageSlice[-1] | ||
| except TypeError: |
There was a problem hiding this comment.
Where would you get a type error here. It would happen if imageSlice isn't listy, but then you've got bigger problems. Are you thinking about the case where imageSlice is a slice object?
There was a problem hiding this comment.
You can get bbox or bbox, origin as well as list-like things
I don't guarantee that I have the minimal logic to cover all the cases, so I should take another look.
There was a problem hiding this comment.
I hadn't appreciated that imageSlice could be a bbox.
|
|
||
| if isinstance(_origin, ImageOrigin): | ||
| origin = _origin | ||
| imageSlice = imageSlice[0] if len(imageSlice) <= 2 else imageSlice[:-1] |
There was a problem hiding this comment.
I must be missing something here too. It seems like imageSlice would only ever be 2 or 3 elements long. If it's 3, it has an origin, if not you want both the elements. Why only pass on the first element?
There was a problem hiding this comment.
The problem is that you can get passed lots of different things:
- bbox
- bbox, origin
- :
- :, origin
- n:m, :
- n:m, :, origin
- n:m, i:j
- n:m, i:j, origin
You don't want to convert bbox to [bbox]
There was a problem hiding this comment.
I see now. It may be worth adding a few more of these as examples in the docstring.
That is, when using the syntactic sugar which makes using bboxes easier,
allow an extra argument such as
im[bbox, afwImage.PARENT]
or
im[1000:1010, -1:, afwImage.PARENT]
In the second case we'll use PARENT coordinates when interpreting the
slices (i.e. the "1000" includes x0)
RobertLuptonTheGood
force-pushed
the
tickets/DM-11579
branch
from
1f346bf
to
d2c76a8
Compare
That is, when using the syntactic sugar which makes using bboxes easier,
allow an extra argument such as
im[bbox, afwImage.PARENT]
or
im[1000:1010, -1:, afwImage.PARENT]
In the second case we'll use PARENT coordinates when interpreting the
slices (i.e. the "1000" includes x0)