DM-12025: make Transform pickleable #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
approved these changes
Sep 26, 2017
python/lsst/afw/geom/testUtils.py
Outdated
| self.assertEqual(transform1.getFrameSet(), transform2.getFrameSet()) | ||
|
|
||
| fromEndpoint = transform1.fromEndpoint | ||
| toEndpoint = transform1.toEndpoint |
There was a problem hiding this comment.
I realize this is pre-existing code, but... for TransformGenericToGeneric the types may match but the # of axes may differ. I worry that this could cause a confusing test failure where you are comparing the results of applying transforms (below).
Please either assert that the corresponding endpoints are equal for the two transforms (Endpoint does define an equality test, though only in Python), or assert that the # of inputs and outputs match for the two transforms.
| @@ -82,6 +82,8 @@ PYBIND11_PLUGIN(_interpolate) { | |||
| "x"_a, "y"_a, "style"_a = Interpolate::AKIMA_SPLINE); | |||
|
|
|||
| mod.def("stringToInterpStyle", stringToInterpStyle, "style"_a); | |||
| mod.def("lookupMaxInterpStyle", lookupMaxInterpStyle, "n"_a); | |||
| mod.def("lookupMinInterpPoints", lookupMinInterpPoints, "style"_a); | |||
There was a problem hiding this comment.
It would be much appreciated if you could add a few simple unit tests for these (including stringToInterpStyle).
r-owen
force-pushed
the
tickets/DM-12025
branch
from
a1235bf
to
7385f6d
Compare
The key functionality was already present (readString, writeString methods) and just needed to be hooked up to the pickle machinery and tested.
These functions were previously wrapped with SWIG, and it's useful to have them wrapped with pybind.
Add tests for lookupMaxInterpStyle, lookupMinInterpPoints, and stringToInterpStyle
Make `assertTransformsEqual` produce a clearer failure if two transforms have a corresponding endpoint that is generic and has a different number of axes.
PaulPrice
force-pushed
the
tickets/DM-12025
branch
from
7385f6d
to
254a6fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key functionality was already present (readString, writeString
methods) and just needed to be hooked up to the pickle machinery
and tested.