DM-10765: Replace existing WCS classes with SkyWcs #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
force-pushed
the
tickets/DM-10765
branch
2 times, most recently
from
7fb39be
to
c20f368
Compare
r-owen
force-pushed
the
tickets/DM-10765
branch
25 times, most recently
from
bf817f0
to
576deeb
Compare
r-owen
force-pushed
the
tickets/DM-10765
branch
2 times, most recently
from
c3e99ac
to
aaa5db2
Compare
No need to test if an item exists before calling remove
Remove tests/sipterms and tests/test_wcs from .gitignore
instead of the deprecated lsst.afw.image.readMetadata
Use lsst.afw.geom instead lf lsst.afw.geom.skyWcs as the module for SkyWcs unpersistence, as per Jim Bosch's recent recommendation
Make the argument `precise` default to False. Test that TAN-SIP is now handled as pure FITS-WCS (due to improvements in AST).
Use the default value of the `precise` argument for SkyWcs.getFitsMetadata when appropriate, which is essentially always.
Update the explanation of why we save LTV1, LTV2
Make formatFitsProperties write the final value of an array instead of skipping entries that have array value. This is much more robust and a better match to FITS usage (which allows the same header multiple times, but readers are only supposed to pay attention to the last value).
and makeSipPixelToIwc and an internal function they call
This is just formatters::formatFitsProperties moved and with slightly tweaked documentation. I'll remove the other function on a separate commit.
Use makeLimitedFitsHeader instead
Use makeLimitedFitsHeader instead
and the associated constant TIGHT_FITS_TOL which describes what the "precise" argument means.
This is analogous to Key::Value and useful in the same way
The old Python functions were already slow, but with SkyWcs they became even slower due to not converting all points with one call. Converting all coordinates in one call to SkyWcs.pixelToSky or skyToPixel requires looping over the catalog twice, which seemed likely to be slow in Python, so I rewrote the functions in C++.
getFitsMetadata could return a WCS with Dec, RA axis order. Fixed by specifying FitsAxisOrder=<copy> for the FitsChan and added a test.
When writing an ExposureInfo to FITS if the WCS has no exact FIT-WCS metadata representation then skip that, instead of writing a local TAN approximation.
r-owen
force-pushed
the
tickets/DM-10765
branch
from
0e2cdf3
to
1f1b661
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.